Matthew McGarvey

@Whaxion thanks for laying it out. And ya, the find implementation was what I was worried about. I'm thinking that we could break this down and maybe you could submit...

@Whaxion "serial" in postgres is an incrementing number data type and we wouldn't want composite key columns to do that. I don't see anything wrong with your composite primary key...

Here's some things that come to mind: - composite primary keys should always be defined **after** the columns they use - I think we could translate the declaration into a...

I see 3 potential problems to solve: 1. For flows, we start the app in a separate process so we will have to make sure the transaction we wrap the...

Right now avram is depending on calling code to handle rollbacks in cases where a transaction already exists. https://github.com/luckyframework/avram/blob/d43f0361ab3c937b8485cf490802482d3005a8f1/src/avram/database.cr#L182-L191 In scenarios where you're testing what happens when a failure occurs...

@jwoertink You're using the instance method of preload with would return a new user with those associations. You want to use the class level methods to add the preloads to...

@jwoertink Can you verify that this is fixed with https://github.com/luckyframework/avram/commit/361a9e84d4b1d3cf35346f6eb361c9388bcaccf0

@jwoertink I believe this has been fixed. There's even a spec verifying SchemaEnforcer with a view https://github.com/luckyframework/avram/pull/555/files#diff-0bd470554a459e4fceec90dca2d35618538153443dfb87154139529eed832206R24-R27

@jwoertink I believe so, but definitely double check

A blocker for this change is that update and insert don't use "from" so a table_name makes sense. For my goals, I think there would have to be a way...