Matthew McGarvey

Results 135 comments of Matthew McGarvey
trafficstars

If it makes anything simpler, we don't _have_ to store the email content. We could just store a reference that we sent this email to that user from this email...

Sounds like mailtrap could be used as inspiration for this feature https://mailtrap.io

So are you saying that you think it's because we are saving things to the database using `spawn`? https://github.com/luckyframework/breeze/blob/5a98f72cd0d5282b6aeb71d1e02fe70ae7c06456/src/breeze/actions/mixins/action_helpers.cr#L16-L25

Here's at least one thing we connect to the current fiber https://github.com/luckyframework/avram/blob/5e29f75371dca5a2bc16858163dc3790cabfbfcb/src/avram/database.cr#L6

I think we want to switch from `URI.encode_www_form` to `URI.encode_path` and we can build the path and only call that method once instead of calling it for each path segment...

Link to where I'm talking about: https://github.com/luckyframework/lucky/blob/3f15bc80cc5d26489dce76ffb5d2486720223ac9/src/lucky/routable.cr#L350-L365 Also, after looking at it again, we don't build the full url in that function so ignore the part about adding it to...

looks like `%20` is the correct handling of spaces. Tested it out here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI

Also need to make sure the generated methods are private as well.

Just in case it becomes a factor, I defined the enum _below_ my `table` block. I don't know how it could be a problem, but I have no ideas on...

Bumping to say that I just ran into this. I can run `crystal spec` on my project and it completes successfully, but if I run `crystal spec path/to/file_spec.cr` it causes...