Daniel Arndt

Results 825 comments of Daniel Arndt

> Should we rename the example to: "relocatable_function" or so to be aligned with the CMake option, the Macro, and the compiler option used? Sure, renamed in https://github.com/kokkos/kokkos/pull/5993/commits/1dcdc404d0772e1faacd462ace7995290ccf17fd.

> Approving but would prefer if you fixed the initialization with argc and argv I'm happy to address that and the other suggestions in a follow-up.

> This should work with llvm/17 and higher which is also what we have in our CI You mean from llvm/13 to llvm/17. 🙂

```C++ #if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300) && \ (KOKKOS_COMPILER_CLANG

@bartlettroscoe I revived this after you asked for feedback wrt https://github.com/TriBITSPub/TriBITS/pull/591#issuecomment-1731599860. It seems we neither need to call - TRIBITS_PACKAGE(Kokkos) at the top of CMakeLists.txt, nor - tribits_package_postprocess in kokkos_configure_trilinos.cmake...

Sure, we should discuss with the rest of the `Kokkos` team if we want to keep `tribits_add_test`.

> I am asking because we are interested in activating rocthrust in our rocm builds. However, currently Kokkos disables rocthrust when Kokkos is built within Trilinos. The simplest way forward...

Set to "ready for review" to initiate some discussion.

@ndellingwood Would you mind testing this pulll request with Trilinos?

> @masterleinad yes, I'll test several configurations sometime later today. Would testing a subset of packages that heavily use kokkos (e.g. kokkos, kokkos-kernels, tpetra, sacado, stokhos), as well testing a...