Daniel Arndt

Results 838 comments of Daniel Arndt

`impl_map` and `impl_track` should be removed.

``` /__w/kokkos/kokkos/containers/performance_tests/TestDualView.hpp:85:11: error: unused type alias 't_dev_exec_space' [clang-diagnostic-unused-local-typedef] 85 | using t_dev_exec_space = typename ViewType::t_dev::execution_space; | ^ 3338 warnings and 1 error generated. ```

@frobnitzem Would you be willing to create a pull request for fixing the issue sinxce your are alreday of the respective places?

We could also base `ndarray` on top of `Kokkos::Array`.

> That appears to be the case - that CI runner previously picked the bundled version. This implies we aren't actually compatible with 3.4.01 but someone more familiar with kokkos...

> In those cases it looks like we had a copy of Trilinos with a (broken) Kokkos installation alongside our bundled Kokkos installation - wouldn't that produce linker errors? If...

It seems we have ``` -- DEAL_II_WITH_TRILINOS has unmet configuration requirements: DEAL_II_WITH_MPI has to be set to "ON". ``` but we then still try to find and use the `Kokkos`...

> I'll take another look later this week but it sounds like the next step is making sure we don't pick up a Kokkos installation from an insufficient Trilinos installation....

Let's see what the `boost` `smart_ptr` developers upstream have to say, see https://github.com/boostorg/smart_ptr/pull/112.

> Kokkos should simply not be doing this. Yes, fixed in Kokkos 4.1.00 (https://github.com/kokkos/kokkos/pull/5804).