Daniel Arndt
Daniel Arndt
@ndellingwood Thanks! That is inline with my testing. The only thing not working yet is disabling tests.
@ndellingwood Would you mind testing that * `-D _DISABLE=ON` * `-D _EXTRA_ARGS=";;;..."` * `-D _SET_RUN_SERIAL=ON` still work as expected from within `Trilinos` with this pull request?
@ndellingwood Are you good with merging this or do you want to pull in someone else from the Trilinos-side before?
> @masterleinad @dalg24 I think we are hitting a bump with the changes here. So far, the AT2 builds in [trilinos/Trilinos#13423](https://github.com/trilinos/Trilinos/pull/13423) are failing due to a change in behavior triggering...
> Let me also try a local build with the `Threads` backend. That worked fine.
> A lot of `IF()` clauses were removed, but the block inside them has not been shifted left, making it inconsistent with the surrounding text. Would be nice to have...
We still need to review (and merge) #6596.
> I was wondering if it would be more appropriate to rewrite `Kokkos::Experimental::inclusive_scan` to directly use `thrust::inclusive_scan` in Kokkos for HIP and CUDA backends. What do you think? Yes, calling...
@vbrunini Would you have a reproducer for the performance degradation? How big is the slowdown?
> Hi @vbrunini - is the performance issue fully resolved? We haven't made any changes related to this issue.