Daniel Arndt

Results 822 comments of Daniel Arndt

Looks like the the test fails when using `std` functions: ``` 4: [ RUN ] hip.mathspecialfunc_cbesselj2y2 4: /var/jenkins/workspace/Kokkos/core/unit_test/TestMathematicalSpecialFunctions.hpp:2132: Failure 4: Expected: (Kokkos::abs(h_cbj2(i) - h_ref_cbj2(i)))

> @masterleinad No I don't think so. I think that's the compiler bug that we discussed earlier in this PR. We just need to disable the failing tests for ROCm...

We still need to disable the tests failing for `ROCm` 5.5 and 5.6.

You'll have to fix the indentation.

> Search for an existing implementation led me to discover implementation of Bessel function by Amos[1]. You can see this is a Fortran code and i am not sure if...

I don't have much to add. You could try explicitly copying the kernel by swapping all `defined(KOKKOS_ARCH_INTEL_GPU)` with `0` in https://github.com/kokkos/kokkos/blob/5ad609661e570ba6aa7716a26a91cb67d559f8a2/core/src/SYCL/Kokkos_SYCL_Instance.hpp#L246-L354.

We tried to reach out to you on slack to discuss this pull request and #7007. Do you have an active handle there?

Looks like the `HPX` backend doesn't work with the changes here.