Daniel Arndt
Superseded by https://github.com/kokkos/kokkos/pull/7065.
The indentation is still not `clang-format-8` conforming.
> There are a lot of failing tests and compilation failures. Are they related to the changes induced by this PR ? I would think so. There are a bunch...
> Would a proposal as follows make sense (at least the concept)? It would be the implementation of the pattern mentioned above: I prefer just calling `fence` before and after...
Is this part of the C++ interface?
Yes, #6511 is going to fix this.
Something like ```diff diff --git a/containers/src/Kokkos_ScatterView.hpp b/containers/src/Kokkos_ScatterView.hpp index 9d04cf6ac..8279db35f 100644 --- a/containers/src/Kokkos_ScatterView.hpp +++ b/containers/src/Kokkos_ScatterView.hpp @@ -773,15 +773,12 @@ class ScatterView
> Shall I make a pull request or do you want to fix it @masterleinad ? If you could create a pull request adding your examples as tests together with...
``` diff --git a/containers/src/Kokkos_ScatterView.hpp b/containers/src/Kokkos_ScatterView.hpp index 9d04cf6ac..fa28d0dc3 100644 --- a/containers/src/Kokkos_ScatterView.hpp +++ b/containers/src/Kokkos_ScatterView.hpp @@ -771,18 +771,18 @@ class ScatterView::accessible, "ScatterView contribute destination memory space not accessible"); if (dest.data() == internal_view.data()) return;...