Maël Valais
Maël Valais
@munnerz When you said: > 3. Add some new way to change what the default `cleanupPolicy` is (that's not linked to the `--enable-secret-owner-ref`) and deprecate the `--enable-secret-owner-ref` field. By "Change...
Hi, I'll be away until 2 Jan 2022. I'll continue reviewing then. You can ask @SgtCoDFish or @wallrj if you need assistance in the meantime.
Hey. It looks very promising! I see that you have added tests everywhere needed. We are very close to being able to merge this! I'll wait for the CI. Would...
I talked about `cleanupPolicy` this morning in the standup. Concerns about the use-cases [in the design document](https://github.com/cert-manager/cert-manager/pull/5324/files?short_path=e927ac6#diff-e927ac6e1b5b0ff19d5b17c40e7bb438e4342256b5ddc4f8fff4ba2c830d87b4) were raised. Specifically, which problems `cleanupPolicy` are solving. Could you help me refine...
I'll approve now and I'll LGTM when the documentation PR is linked, this branch rebased, and (optionally) the envtest-based tests turned into fake clientset tests. /approve
Thanks! Now that this PR contains a link to the documentation PR, we can go ahead and merge this one. LGTM! /lgtm (This PR will need fixing some conflicts)
For anyone using `lpass`, I found that using `--sync=no` solves the problem. What's super weird is that Ctrl+C doesn't do anything...
Hi! What is the current state of the `--deps-only` idea? (mainly for dockerization)
I noticed that logex now has a version with a LICENSE file: https://github.com/chzyer/logex/releases/tag/v1.2.1
Why was this PR closed? I am interested in using dnsproxy in Kubernetes with [cert-manager](https://github.com/cert-manager/cert-manager/), but I cannot find official container images. Is there a plan to maintain official images?...