Maël Valais

Results 231 comments of Maël Valais
trafficstars

Hey, I'm struggling trying to reproduce this. Can you help us with some instructions on how to reproduce the environment? Thanks. One thing we could try doing first is to...

Hey, would we have issues we the number of GitHub Action minutes if we start using them more and more? Just in case, I've asked the CNCF, and they already...

Hey, here is a detail of where each permission is being used: | Pod | Type | Verb | Resource | Why? | |-------------------------|-------------|----------------|----------------|-------------------------------------------------------------------------------------| | cert-manager-cainjector | ClusterRole | list...

Hey. It looks like the OpenSSF Scorecard project migrated from https://securityscorecards.dev/ to https://scorecard.dev/ in April 2024. I found that out in https://github.com/ossf/scorecard/pull/4041 but there are no other mentions of that...

I will continue this on Monday, Aug 19th if that's OK. I really enjoy working with Makefile Modules.

Thanks for the review, Tim. For context, I paused working on this because I have been focusing on [VC-35568](https://venafi.atlassian.net/browse/VC-35568 "AGENT: Show a warning in the Pod's events when the Venafi...

Thanks for working on the GitHub Actions. I've looked at them and they look OK. Let's merge this and try releasing v1.1.0-alpha.0 to see if everything works.

By the way, I don't understand why we have set a client timeout of 1 minute in Key Pair service account mode... Timeouts are a good practice in most cases,...

> Add some comments in the code, explaining why the collected data is compressed > using GZIP....to reduce the likelihood of exceeding the maximum request body > size limit imposed...

I realize that this PR is trickier than anticipated. @j-fuentes told "if it is low hanging fruit, just enable compression; if it is not low hanging fruit, discuss further actions"....