Maël Valais

In the OP's case, ingress-nginx (>v1.0.1) already picks up ingresses that have the `nginx` annotation, which can be configured with `--ingress-class`. I have looked at [13 ingress controllers](https://docs.google.com/document/d/11YrnTqale4ICnR9SFMttCoRL4-NEvQJookNfFb3QjYA/edit#bookmark=id.d18oj1hja37t), and the...

The flag `--max-concurrent-challenges` that defaults to 60 was introduced in https://github.com/cert-manager/cert-manager/pull/1671. There isn't any context as to why this flag was added. I don't understand the reasoning behind `--max-concurrent-challenges`. Why...

**🎯 Release 1.12:** We will have a code freeze for 1.12 starting Wed 19 April 2023. The code freeze will be waived after the release of 1.12 on Wed 26...

I can take a look tomorrow morning.

I looked into the feasibility of an e2e test, and it seems totally feasible. I pushed an example of what the e2e could look like: https://github.com/joshmue/cert-manager/compare/vault_client_cert_auth...maelvls:cert-manager:vault_client_cert_auth_tests To run this e2e...

I was also getting this error, it was due to a mistake on my side (I was using `v1/auth/cert` instead of `cert`). I had mixed myself up with these paths....

We are really close to being able to merge your work, congratulations! The last step is to open a PR to document this new feature in the page [configuration/vault.md](https://github.com/cert-manager/website/blob/master/content/en/docs/configuration/vault.md). I'll...

Hi! I'll be spending time reviewing this PR today. @alijahnas A few questions: 1. Which version of ingress-nginx are you using? 2. What is the value of your Issuer's `spec.acme.solvers.http01.ingress.class`?...

Hey @dsonck92. Thank you so much for the PR! Using a flag to "toggle" between the annotation mode and the ingressClassName mode seemed OK to me at first, but I...

Hey, I'll enable the tests (I had forgotten to enable them) /ok-to-test Apologies for the delay on the review. I'll ask the current release managers (Richard and Ashley) to help...