Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

Thanks. Leave closing this issue up to you, depending on whether you want to leave it open as a reminder for this documentation todo or not.

Unfortunately, your proposed solution does not work for raster I believe. Taking the README example and changing `layer_spatial()` to `annotation_spatial()`: ``` r library(ggplot2) library(ggspatial) load_longlake_data() ggplot() + # loads background...

In https://github.com/lorenzwalthert/precommit/issues/571, @jeancochrane added the results of her detailed investigation, basically confirming the impression I had that it is a concurrency issue. To me, the fact that `getCachePath()` creates directories...

Thanks guys for the detailed discussion. I approve of this change. Also thanks for your contribution @plietar. I don’t have the bandwidth to work on this repo anymore myself, but...

@assignUser I suggest to pause the CRAN release process until you implemented more features.

The problem is that I was using `attach()` and the CRAN maintainers did not like it, although I followed best practices (see `cran-comments.md`). We might have to export `expr_eval()` to...

Good idea! We'll have to try that I think...

Well I have a list I once mentioned... Will try to put the items out as issues. Things on top of my mind: * API review, i.e. * `benchmark_run_ref()` should...

* API: Ok. If you have time, you can review it and propose the changes. Not sure we want to hard-deprecate the old functions already now 🤔. Probably we could...

Yes. If you want to submit to CRAN, and / or become maintainer, I am happy to transfer the GitHub repo over. I don’t have time to work on this...