Christian Lorentzen

Results 319 comments of Christian Lorentzen
trafficstars

@jameslamb I'm sorry, I really need a maintainer's help. The tests in `tests/python_package_test/test_dask.py` fail even on the master branch, locally on my computer. I tried to play with different versions...

The remaining CI failures seem unrelated. TODO for myself: Improve test coverage a bit.

@EYezerets Thanks you for proposing this interesting sampling idea for trees/forests (if it stems from Breiman, it's even quite old :smirk:) As a non-expert for trees and forests, I, personally,...

A priori, I‘m +1 of only allowing X and y on the same device. I‘m also +1 to allow y on a different device and scikit-learn moving it to the...

@ogrisel The segfault also occurs for linux, see CI results. (For Windows, this PR needs a slight update with C macros). I need this PR to work in order to...

> Do you need help with debugging? Yes. I have no clue how to debug that segfault. But note that I don’t know if it’s worthwhile.

Seems to be related to `PyDataMem_DefaultHandler` as a simple C ``` PyObject *current_handler; current_handler = PyDataMem_DefaultHandler; ``` within scikit-learn triggers the segfault.

Update: The segfault has been solved with the help of [numpy#29600](https://github.com/numpy/numpy/issues/29600) (`cnp.import_array()` was missing). Now, I struggle with numpy include dependencies. The build does not find the function `PyDataMem_SetHandler`, but...