Christian Lorentzen

Results 337 comments of Christian Lorentzen

> I would just suggest someone carefully checks that this does not lead to any API change. This PR makes the following public API change: If `multi_class = "auto"` (effectively...

@ogrisel Thanks for reviewing. I would prefer if you did not push commits on (my) PRs. Please first communicate with me.

@virchan While a certain time delay is not an issue, it is a bit strange that all my review comments are marked as resolved but no new commits were pushed.

Sorry for the back and forth: Could you revert the last changes with the response_method_name c4ec0e8993363740463a253997d08779c8913885. It seems cleaner after all.

Let's get this in. Postponing edge cases and advanced features. For the naming, let's vote (non-binding) with :+1: and :-1: :

`FrozenEstimator`

`PretrainedEstimator`

`ImmutableEstimator`

`ReadOnlyEstimator`

@scikit-learn/core-devs @scikit-learn/communication-team @scikit-learn/contributor-experience-team @scikit-learn/documentation-team Your v(non-binding) vote for names could help @adrinjalali in finishing this PR.