Christian Lorentzen

Results 319 comments of Christian Lorentzen
trafficstars

I had a quick lock at the QuantileRegressor. In this particular case I think you should either deprecate or internally call the scikit-learn implementation. Calling a scipy minimize routine on...

While I really like good visualisations, I am -1 on this one. With the plot library of your choice, it should be straightforward to produce a Sankey diagram with the...

> Though it should, it is not that straightforward to produce a sankey plot for a confusion matrix based on matplotlib (on which scikit has a hard dependency) Scikit-learn is...

https://github.com/matplotlib/matplotlib/issues/28227 may be linked.

As @betatim said > I think it would be nice to have this as part of the visualisations in scikit-learn. I agree with that. I am just hesitant to have...

Numpy 2.0 compatibility of all dependencies is available: - [contourpy 1.2.1](https://contourpy.readthedocs.io/en/latest/changelog.html#v1-2-1-2024-04-02) - [matplotlib 3.8.4](https://github.com/matplotlib/matplotlib/releases/tag/v3.8.4) - [numba 0.60](https://numba.readthedocs.io/en/stable/release/0.60.0-notes.html) - [pandas 2.2.2](https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0) - [pyarrow 16.0.0](https://arrow.apache.org/release/16.0.0.html) - [scikit-learn 1.4.2](https://scikit-learn.org/stable/whats_new/v1.4.html#version-1-4-2) - [scipy 1.13.0](https://docs.scipy.org/doc/scipy/release/1.13.0-notes.html) -...

Maybe th AutoARIMA from https://github.com/Nixtla/statsforecast could be an alternative for pmdarima?

One of the main disadvantages, in my opinion, of `statsforecast` is its dependency on numba (which depends on llvmlite which is heavy) - but darts depdends on other libraries such...

Could you now mark the failing tests with pytest‘s xfail? Then another PR can fix the gradient.

@jameslamb Thanks for your suggestions. Could you already comment on the deprecation strategy, raising a warning? Then, should I adapt all the (scikit-learn api) python tests and replace eval_set by...