Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

thanks for reporting. This was not discussed earlier, so need to look into it. Also, if this is false-positive (i.e. reported by `UBSan` `without any real undefined behavior at run-time),...

Reopening it, for now, we can discuss it in the next community meeting how to handle this.

Scope object is meant to control the Span reference life cycle inside Context - It attaches Span to Context during creation and detaches during destruction. Creating Scope objects without Span...

`vcpkg` toolchain configuration using `CMAKE_TOOLCHAIN_FILE` is only supported for Windows. For Linux platforms, dependency should be already met externally before building opentelemetry-cpp. Removing `bug` label as this is expected behavior....

> It could still be something in my scripting. I’ll continue to look at it. Thanks @Kurt-Rayner-Alpha . Seems we would need your help in troubleshooting, as I tested it...

@Kurt-Rayner-Alpha - Did you find anything further on this, as this is not reproducible for us locally ?

@ThomsonTan - Hope it's fine to assign to you, as you know the Jaeger exporter code better :)

@maxgolov - agree it should work seamlessly unless we want to support client authentication ( and hence provide Client certificate through our callback) which needs to be tested. The issue...

@pavanshahm - Thanks for this. It would be good to have SSL certificate check integrated. Couple of comments here: 1. Can we avoid adding code to build curl with SSL...

@owt5008137 Thanks for reporting these warnings. It would be definitely helpful if you raise PR for fixing these warnings. Please go ahead and raise a PR.