Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

> > BTW: Why don't we upgrade gRPC to the latest version of gRPC(v1.48.0)? > > Yes. we can try upgrading to gRPC v1.48.0, and/or bazel v4.2.2. Saw somewhere that...

Good point. We should - - Either not use gtest_add_tests() to add unit tests. (preferably) - Or make the minimum required cmake version as 3.9.

> old cmake compatible example can be found here: > > https://github.com/open-telemetry/opentelemetry-cpp/blob/521ebd8f51fb27219c8dd581629ec1b93df8b70a/sdk/test/trace/CMakeLists.txt#L1-L30 This example seems to be using gtest_add_tests at line 21, or am I missing something ?

To see if we can use the gtest_add_tests() function from cmake module: https://github.com/Kitware/CMake/blob/908d2cd136be3165d391c18777890798a18f96c3/Modules/GoogleTest.cmake#L293-L294

There are few more cmake constructs in code not supported in cmake v3.1.0: https://github.com/open-telemetry/opentelemetry-cpp/blob/a847d0ce42209e458f8f98a5751626a33adfad95/CMakeLists.txt#L9 https://github.com/open-telemetry/opentelemetry-cpp/blob/76c664a20b8219b91ead69ded6b7ee873b1a85ba/ext/test/http/CMakeLists.txt#L4

@esigo - I have gone through the circular reference between `meter_context meter`, and `meter_context metric_collector`, and I don't think it would be easy to avoid them. These changes look good...

This was discussed in today's community meeting - Should we instead remove validating CI builds for old metrics implementation? This would simplify the CI, and also gives a message that...

Did a quick test with this PR on Linux, by creating an instrumented library with `-fvisible=hidden` flag and the library is able to use the singleton tracer provider from the...

@owent - We agreed this PR to be scoped for Linux and Mac. Let us know if you have any comment on that.

Is it different from #1428? If yes, can we add more information to this issue? Thanks :)