Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

> I personally would prefer STD->Abseil/GSL->Non-STD. It's encouraged to always use non-std libraries to maintain ABI compatibility ( https://github.com/open-telemetry/opentelemetry-cpp/blob/main/docs/abi-policy.md#application-binary-interface-abi-policy ). While there are macros switches provided to use other libraries,...

> We currently use a coarse-grained switch HAVE_CPP_STDLIB to control all these things. As a result, we cannot enable any of them. Do we have a use case why do...

I don't see the gcc-7.3.1 toolchain available for ubuntu to validate, fix and test this issue. And build doesn't fail with gcc-7.5.0. Have tagged this issue for help.

> I gave up on the library, because my first attempt at using it promptly crashed. I don't care any more. Sorry for your experience. Issue has been tagged as...

Tagging @meastp @owent FYI, and if they would like to add more details here.

Thanks, @meastp @owent for all the details above, and for bringing the clarity on changes required to support building DLLs. The priority is definitely equally for all the platforms and...

> If I continue working on my test by incorporation the approach outlined for supporting both header-only and src files (and publish this as a branch (on my github fork)...

Thanks, @meastp. Also tagging @ThomsonTan @maxgolov for review.

After #563 ( tracestate integration ), 9 tests are still failing. keeping it open till it's fixed. ``` STRICT_LEVEL: 2 harness listening on http://127.0.0.1:7777 test_multiple_requests_with_illegal_traceparent (__main__.AdvancedTest) harness sends an invalid...

Moving to GA milestone, as fix doesn't involve api/sdk interface changes. And few of the failures are related to issues with the test suite used for validation.