Lalit Kumar Bhasin

Results 480 comments of Lalit Kumar Bhasin

My proposal to have cleaner design: - All Protobuf messages are currently generated under `src/proto/tonic`. These should be restructured (logically, not physically) into `proto::opentelemetry::proto::*` - All gRPC service code (ie...

closing this, as this will be covered through #3045.

Have done a POC for adding a custom thread runtime implementation for the Runtime and RuntimeChannel [abstractions](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/runtime.rs). This uses `futures_executor` for executing the future, and `std::mpsc` for channel (which can...

`opentelemetry_sdk::TracerProvider::span_processors()` is not part of Otel specs, and also application is not supposed to directly invoke any methods from processor. Though, the use-case is not very clear. So, the HTTP...

Thanks @demurgos for the details, it gives more clarity now. @cijothomas @TommyCpp if you have comments regarding exposing the `TracerProvider::span_processors()` method, and letting applications explicitly call the `processor.on_end(spandata)` for the...

I'm considering whether we should also remove the `with_simple_processor` and `with_batch_processor` API methods, as they are simply convenient wrappers around `with_span_processor`. It doesn't seem necessary to support multiple APIs for...

Current update on the options tried : This get's complicated to support. The generic solution would be adding &str variant type to `StringValue`, however adding any such lifetime specifier propagates...

Have opened a discussion with the tracing folks - https://github.com/tokio-rs/tracing/discussions/3073. Also with the trait definition for the `tacing::field::Visit::record_str` method, it is not possible to extend the lifetime of str reference...

Thanks for the PR. Couple of comments for now: 1. any reason for using [atomic_shim](https://crates.io/crates/atomic-shim) instead of [portable-atomic](https://crates.io/crates/portable-atomic) ? Haven't used either of them, but from the stats (number of...

@3g0r This looks to be valid issue. The protocol is selected based on the feature flag, or the ExportConfig provided by the application. Env variable is not considered. Would you...