Lalit Kumar Bhasin

Results 480 comments of Lalit Kumar Bhasin

Some old thread in rust community - https://users.rust-lang.org/t/fast-get-current-time/10381/2. It talks about using [coarsetime](https://github.com/jedisct1/rust-coarsetime) or directly using [libc](https://crates.io/crates/libc). > like checking system Ticks since start and using that to populate timestamp....

Some comparison between `SystemTime::now()` and directly using `libc::clock_gettime()`: ```rust fn get_libc_clock(tv: &mut timespec) { unsafe { libc::clock_gettime(libc::CLOCK_MONOTONIC_COARSE, tv); } } fn benchmark_time_methods(c: &mut Criterion) { c.bench_function("SystemTime::now", |b| { b.iter(|| black_box(std::time::SystemTime::now()));...

Agree on this. If we are always going to populate the textual representation of SeverityNumber here, there is no point of populating it in SDK. Let the exporter decide if...

Also, the field is optional as per the log data model - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-severitytext

Discussion in community meeting - Having getters for LogRecord, and make existing fields to private. - Remove severity_text from LogRecord.

@howardjohn If you'd like to contribute the fix, please feel free to proceed. We eventually plan to eliminate the dependency on the async runtime for batch processors. I'm currently working...

Assuming [SimpleConcurrentProcessor](https://github.com/open-telemetry/opentelemetry-specification/pull/4163) is part of the specs. The simple solution could be - Add static dispatch for `SimpleLogProcessor` and `SimpleConcurrentProcessor` because their types are known at compile time. - We...

> solution would be either to move versions up lockstep and disregarding semver (or at least broadening it's definition to cover all the various crates), or alternatively document for each...

``` Some(tracing_opentelemetry::layer().with_tracer(tracer)) | ----------- ^^^^^^ the trait `opentelemetry::trace::Tracer` is not implemented for `opentelemetry_sdk::trace::TracerProvider` | | | required by a bound introduced by this call ``` @ibigbug You need to modify...

@Ilmarii The current behavior is as follows: If resources are specified during the creation of the `LoggerProvider`, those resources will be used as the final set and will not be...