Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

Thanks, have tagged this as help wanted, for consistent reproduction of the issue, to allow debugging it further.

LGTM. would be good if we can get it reviewed it from @eduardo-camacho or @kindbe too.

> I'll double check and get you a matrix! @SahilAshar - Did you have a chance to validate this?

Looking into the boost docs, [demangle](https://www.boost.org/doc/libs/1_63_0/libs/core/doc/html/core/demangle.html) is defined within `boost::core:` namespace, while 1ds-cpp-sdk defines it as static inline in global namespace. So, unless you are doing namespace pollution in the...

Regarding including the correct offline storage files, isn't it is already handled here - https://github.com/microsoft/cpp_client_telemetry/blob/b35fe2d8f5709c9d50dc5a39ffac87768e215ce3/lib/android_build/maesdk/src/main/cpp/CMakeLists.txt#L107-L115 So Room DB files should be included only if build with `USE_ROOM`. This way, it...

Similar reasoning for HTTP library - https://github.com/microsoft/cpp_client_telemetry/blob/b35fe2d8f5709c9d50dc5a39ffac87768e215ce3/lib/android_build/maesdk/src/main/cpp/CMakeLists.txt#L117-L121

It seems [OfflineStorageTests_Room.cpp](https://github.com/microsoft/cpp_client_telemetry/blob/caf66698e04e885929716abc709b1224ac1974ad/tests/unittests/OfflineStorageTests_Room.cpp#L568) tests for SQLite, Room and Memory based on where we run it. In that case, we can check if OfflineStorageTests_SQLite.cpp brings some extra tests, and then do...

> in our telemetry, we have 602,492 users with reported 2,772,579 crashes of the same issue in less than 30 days. @mosunchao - Is there a specific pattern whether it...

@SoundersFan - Just wondering if you have a plan to contribute a fix for this as we discussed in the community meeting some time back?

@SoundersFan - Just checking on your plans to contribute fix for this issue. Thanks :)