Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

Thanks, @marcalff for summarizing the discussion, this seems to cover all the aspects. Just to add, while the USER-DOC is stored/published in the opentelemetry.io, we can still maintain the links...

@svrnm - Just curious how is the version mapping managed between SIG releases and it's documentation in opentelemetry.io, or if you know how other teams are handling it. In readthedocs.io,...

Thanks for raising the issue. I like the second approach, though it needs some design discussion. As we are nearing the Release Candidate, have added it for the next milestone...

Moving to post GA, as we already have initial set of documents in opentelemetry.io - https://opentelemetry.io/docs/instrumentation/cpp/manual/

I am a C++ maintainer, and if it helps, I can be a member to review/approve prototypes in C++.

Changes looked good to me initially, but I didn't think about the backward compatibility aspects. In existing setup, there is nothing stopping the applications to build their own logic around...

pasting here from the 1ds-sdk team's channel - Hi team. We are observing significant memory spiking and leaks with 1-DS on iOS devices. I'm attaching a snapshot from the leaks...

Adding @eduardo-camacho as reviewer, as he has written this part of iOS code.

> Effectively this change is more disruptive than previous version when Lalit commented about the global static, and the global static thing is still present; am I missing something here?...

@sulahane - Do you plan to debug this further as you have reproduction of the crash? It is difficult to get the root cause from the stack trace shared. Also,...