cpp_client_telemetry icon indicating copy to clipboard operation
cpp_client_telemetry copied to clipboard

OfflineStorageTests_SQLite.cpp : reenable the tests

Open maxgolov opened this issue 5 years ago • 3 comments
trafficstars

Tests were disabled at some point. Need to investigate why and re-enable those again.

maxgolov avatar Sep 16 '20 19:09 maxgolov

It seems OfflineStorageTests_Room.cpp tests for SQLite, Room and Memory based on where we run it. In that case, we can check if OfflineStorageTests_SQLite.cpp brings some extra tests, and then do cleanup. You can assign it to me if needed.

lalitb avatar Sep 22 '20 05:09 lalitb

@lalitb is correct: OfflineStorageTests_Room tests SQLite and Memory on all platforms, and SQLite, Memory, and Room on Android (the Android unit test image links both Room and SQLite). OST_R was written as a pinning test for the Room implementation to ensure that it was doing the right (or at least the same) thing.

+1 to looking at OfflineStorageTests_SQLite to see what it would add to the mix. I would be surprised if I had managed to build the ultimate comprehensive test and cover all the cases in the older test.

larvacea avatar Sep 22 '20 18:09 larvacea

Sounds good. I assigned to @lalitb

maxgolov avatar Sep 22 '20 18:09 maxgolov