Gediminas Morkevicius

Results 92 comments of Gediminas Morkevicius
trafficstars

sqlmock is used for testing purposes, not for in memory db. you can still implement your functional tests very efficiently by using sqlite (if you just use SQL standard queries)...

As I said, sqlmock is meant for unit testing certain functions or blocks of logic. It would not be wise to use it for functional tests and try to test...

Hi, maybe you are willing to contribute this patch? Haven’t used golang for more than a year, would be difficult to find a willing to

this one is interesting, since the error is returned by Close and this function is called by go sql. it just does not return that error for some reason. and...

from what it seems, go does not lock the connection for the statement. and if the connection dies it will just open another one. for transactions the connection is locked...

it [cannot](https://github.com/DATA-DOG/go-sqlmock/blob/master/sqlmock_go18.go#L88) return an error. can you provide your test case implementation or minimal test in order to reproduce it? Currently Ping is not mockable, but it does not return...

yes that makes sense @mhemmings thanks for pointing it

Your code does not use an sqlmock db in your http server function, instead it opens mysql. If you would not just defer close sqlmock db, but instead check if...

Hi, if you haven't found a good suitable standalone urlizer maybe it is worth to separate as a package

some time ago @everzet has made the same transliteration tool separate [in repository](https://github.com/Behat/Transliterator) that should be the same in functionality..