Gediminas Morkevicius comments

Results 92 comments of


                                            Gediminas Morkevicius

trafficstars

db.Close() only sometimes satisfies mock.ExpectClose()

Hi, very likely then that from some go version it now closes db in separate go routine and though synchronously we can no longer receive the close call to the...

Adding code to run on Powersystem

Hi, this package is not using unsafe, just mimics the standard sql driver. I do not see the point in testing different archs, which are supported by go.

Question: how to use with postgres text[] field?

Hi, it requires a ValueConverter registered through the sqlmock.Option. if the driver you use provides those ValueConverters, you should just register them. Otherwise you may need to copy them from...

Invalid regex not reported as so

Hi, probably should follow as an improvement to #158 in order to tell whether sql was not matched

go-sqlmock with gorm

I think your expectation is wrong, instead of ExpectQuery seems like there is ExpectExec needed. Update and insert statements are not Query

When expectations are not met show received argument values

Hi, I agree this could be helpful, but currently I’m too busy with a child. If you could contribute it, that would be useful

Unable to mock the rows.Columns() error

Hi, at the moment I do not think this is mockable, probably worth looking how it could be added. Regarding RowsWillBeClosed, it just adds an expectation that the mocked rows...

Unable to mock the rows.Columns() error

will be added to #187 at some point

Why this sql not match when using postgres?

Sqlmock is based on a standard sql driver interface. It will not try to adapt to different frameworks, which use it in non standard expected ways. So you can just...

GORM model with time.Time type error

Sqlmock is a mock database, it does not know that you use gorm or any other thing underneath. If you use non standard arguments to sql value converter. You need...