ImageBundle icon indicating copy to clipboard operation
ImageBundle copied to clipboard

Be able to slug non-latin1 names

Open Gregwar opened this issue 12 years ago • 6 comments

As said by @Hast in #40, we should be able to slug pretty name in a better way, using, for instance this component:

https://github.com/l3pp4rd/DoctrineExtensions/blob/master/lib/Gedmo/Sluggable/Util/Urlizer.php

Wouldn't it be overkill? What component/code/dependency should we use?

Gregwar avatar Nov 06 '13 19:11 Gregwar

Sluggable urlizer is definitely the best solution. But issue is that it's part of l3pp4rd / DoctrineExtensions package. Copying Urlizer component is not a good idea as well as making whole package a dependency for Image component. What else do we have?

It would be great to move Urlizer component to a separate package, because as I said it's the best solution I've found and it's highly reusable and useful for many situations. But I'm pretty sure @l3pp4rd will not agree to do this.

I also agree that Urlizer has much more functionality that we need here. So this is should be discussed.

ozahorulia avatar Nov 06 '13 22:11 ozahorulia

Hi, if you haven't found a good suitable standalone urlizer maybe it is worth to separate as a package

l3pp4rd avatar Nov 09 '13 21:11 l3pp4rd

Hi! Nice to see that you have noticed about this issue.

Don't know what @Gregwar would say about using urlizer as a dependency for Image lib, but as for me separating urlizer as a package is really good idea. I actually wrote previously why it is so. So I'd be happy if you agree to do that. As well as many other developers who are seeking for such package as a standalone library.

ozahorulia avatar Nov 09 '13 22:11 ozahorulia

Hi

I guess you could either move that to an new lib or create a "read only" repository that would just contain the urlizer from DoctrineExtension (like Symfony did with its forms for instance)

Gregwar avatar Nov 09 '13 22:11 Gregwar

@l3pp4rd so what do you think?

ozahorulia avatar Jan 27 '14 16:01 ozahorulia

some time ago @everzet has made the same transliteration tool separate in repository that should be the same in functionality..

l3pp4rd avatar Jan 27 '14 17:01 l3pp4rd