Kyle Tsang

Results 135 comments of Kyle Tsang

Thanks for the PR. You just need to add `disabled`, not `disabled="true"`: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/disabled

Looks like there are some stuff in [bootstrap's typography section](https://getbootstrap.com/docs/4.5/content/typography/) that could be wrapped up into simple components. Is this a good idea @jquense?

@Radhesh-Sarma I'll have to look into this and fix/test on my end. Here's an issue that should be a good one to take: #5944

Can you post a code example of what your component looks like?

For animated placeholders, they currently work like in the regular bootstrap markup where the placeholder with the animation prop must wrap the actual placeholder with the width. For example: ```...

Here's the instructions for running the project: https://github.com/react-bootstrap/react-bootstrap#local-setup In terms of the fix for this, I think we just need to setup a new Algolia key for the v4 docs....

@cyonder, can you share a codesandbox showing the issue?

Modal does take a `container` prop where you can specify where the modal gets appended to. Not sure why it's marked as private though... @jquense? https://github.com/react-bootstrap/react-bootstrap/blob/00dffcd69cfe0350a77a3037585388298432b32a/src/Modal.tsx#L213-L216

Can you put this into a codesandbox for us to debug? Thanks.

We don't support v0.x anymore. I modded the sandbox for v1 (Bootstrap 4) and don't see the issue anymore on Chrome: https://codesandbox.io/s/react-bootstrap-demo-forked-50ubj?file=/src/App.js