Kyle Tsang

Results 135 comments of Kyle Tsang

Hmm I'm not sure about this. I'm thinking it should be possible to handle the scrolling using the current rendering API, but maybe it's easier to visualize with an example?

I just tested this on Ubuntu 18.04 and it works. I guess it is a Windows issue :(

Looks like docs need to be updated for v5. Dropdown just takes a regular node as children now, not a function. There are also some other API changes regarding what...

Would you be interested in using [react-bootstrap](https://react-bootstrap.github.io/)? You still use the Bootstrap stylesheet, but the components have been re-written and optimized for React. As mentioned in #35665 there are compatibility...

Not sure what's happening here. It is adding the `slide-exit-done` class, but not the ones for exit and exiting. This looks like an issue somewhere in react-transition-group.

@jquense, I guess we could expose some props here, but I wonder if we should just split the component and require the user to enter PageItem and PageLink separately?

It seems like this only guards against the case where the user explicitly defines `this: T` in the callback? If you set up the above example as below, it would...

You'll have to remove `required` to avoid using browser validation since you're looking to use custom validation. Also, there's two props `isValid` and `isInvalid` that will control the styling for...

Remove `validated` prop from `Form`. I believe that's used for client side validation as well

The initial rendered position is wrong, but once you scroll, it corrects itself. As a workaround try adding `renderOnMount` to the dropdown menu.