Kyle Tsang

Results 135 comments of Kyle Tsang

We should expose the existing `AccordionCollapse` transition callbacks on `AccordionBody` instead (ie. `onEnter`, `onExit` etc). As for the open/closed state in the callback, you could use your `activeKey` state and...

`use client` is already inserted by our babel plugin during the build. Are you running into issues with the latest version of react-bootstrap?

You're running into the issue described here: https://github.com/react-bootstrap/react-bootstrap/issues/6669 Unfortunately you won't be able to use the dot notation for components (`Dropdown.Item` for example). You'll have to import `DropdownItem` and use...

Can you provide an updated sandbox link? The current link says "not found"

When you shift tab, the base modal captures the key press and ends up focusing on the modal dialog div, although that's been set with a tabindex of -1: https://github.com/react-restart/ui/blob/main/src/Modal.tsx#L383...

Seems ok to me, although you should really use a label where possible for accessibility purposes.

The original workaround that @jquense added to fix this doesn't work in the shadow DOM because `currentEvent` is undefined https://github.com/react-restart/ui/blob/44dc346744b37c33bd0d0309e5cd827751fce9c4/src/useClickOutside.ts#L104C9-L104C9 As a result, the click handler is processing twice

> Funny I just saw that material UI has a different work around for the same issue in their ClickAway component, maybe we can try that? Unfortunately couldn't get tests...

Upstream issue: https://github.com/vercel/next.js/issues/51593

Thanks for opening the PR. Is there a Docusaurus plugin for this? We're currently in the process of migrating to Docusaurus, so all the existing docs code will be deleted....