Kyle Holmberg

Results 293 comments of Kyle Holmberg
trafficstars

There's also still something wrong with this PR 🤔 On `master` `npm run test` doesn't fail, but seems to have the same output. Will dig in more. I like the...

It's because of missing coverage, and I'm not quite sure how to get those last bits of coverage. Comments in test code. I'll take another stab at this and the...

@insin do you have any plans on changing how nwb exposes/shares it's configuration? We're creating a PoC using NWB for a UI library, and we're gonna try using the above...

With that setup my storybook isn't matching the babel configuration that `nwb` is using.

If changes are made by overriding key-value config pairs in `nwb.config`, they're not easily shared in a palatable format for Storybook (who is looking for `.babelrc` or a custom Webpack...

For `useDeepCompareEffect`, how about [this](https://github.com/kentcdodds/use-deep-compare-effect)? For `useCustomCompareEffects`, how about comparing 2 objects by hashing them and comparing their hashes rather than a deep compare?

`usePreviousDistinct` done ✅

This is a relatively easy project to get involved with contributions! Maybe you'd be interested in opening a PR yourself for it?

If we don't plan to implement `useBeforeUnload`, maybe we should strike it from OP?

That being said, maybe there's something to be said for NOT porting this hook if it's so easy to accomplish with `useEventListener`