Kyle Holmberg

Results 292 comments of Kyle Holmberg
trafficstars

Couldn't `resolutions` solve your problem?

https://github.com/rogeriochaves/npm-force-resolutions just trying to give you a workaround for now. @zimme I haven't used `prettier-eslint` for some time, but with the advent of https://github.com/prettier/eslint-config-prettier/pull/175 I'm wondering if the library should...

It didn't seem like `optionalDependencies` was what we wanted. https://docs.npmjs.com/cli/v7/configuring-npm/package-json#optionaldependencies > Entries in optionalDependencies will override entries of the same name in dependencies, so it's usually best to only put...

@JonDum the warnings are expected, but you should still end up getting the latest version. You can verify by looking at the resolved version in the lockfile. Also, see my...

I have no idea why CI didn't run with that merge commit...

I know this project isn't a focus for you, so I appreciate the attention you're giving it for us to get this PR out. I'm no expert on this, so...

Oh! I didn't realize. Okay, I agree those are optional, but I feel like we still have it right as-is. Let's say somebody wants to use their own version of...

```js if (['.ts', '.tsx'].includes(fileExtension)) { formattingOptions.eslint.parser = formattingOptions.eslint.parser || require.resolve('@typescript-eslint/parser'); } if (['.vue'].includes(fileExtension)) { formattingOptions.eslint.parser = formattingOptions.eslint.parser || require.resolve('vue-eslint-parser'); } ``` I've got nothing on this 😬 You're suggesting this...

Shit. Duh. Sorry. Fix in the morning.

Some updated dependency is logging a warning in test: ``` No parser and no filepath given, using 'babel' the parser now but this will throw an error in the future....