Kyle Holmberg

Results 293 comments of Kyle Holmberg
trafficstars

To explain: it did and we fully intend on doing so again. Prettier changed the defaults and we just never updated it here. Should be a very simple PR!

Hey @timruffles I know it's been a hot minute, but I'm spending a few hours a weekend working on this repo and `prettier-eslint`. Feel free to resolve the conflicts, and...

@bj00rn any context here could help. Did you follow through on https://github.com/prettier/prettier-eslint-cli/pull/144#issuecomment-502588064 Should this be merged?

1) Was an honest mistake! Easy to correct. 2) I'll have to dig a bit deeper this weekened.

peer versions are still required. it seems in the past this CLI has supported a range of versions of `prettier-eslint` at a time. This means `prettier-eslint` is ideally a peerDep...

I disagree 🤷🏼 `prettier-eslint-cli` is a tool that runs `prettier-eslint` from the CLI. It's an abstraction atop another tool. Embedding the other tool seems like a mistake. It's like glueing...

No, because the package would be bundled with one version regardless of the expressed range in `package.json`

Or we could just list it as a peerDep! > dependencies are not bundled But they _are_ in `node_modules` which can affect module resolutions of other deps.

I've been using google to figure out the installation behavior of `npx`, but I'm not finding anything to suggest that `npx` ignores `peerDependencies` when it installs the binary's `dependencies`. Do...

> Is there any downside if we go with my dirty solution here? We'll support peer with/without at the same time. Yes, people that use both `prettier-eslint` and `prettier-eslint-cli` would...