Kimish Patel
@Maratyszcza would love to get your inputs here. Thanks!
> Thanks @kimishpatel Overall I'm still not understanding why capping the # threads requires the bulk of the changes here. > > Is there a simple explanation? Not sure what...
> My biggest concern is that this code doesn't do what you expect: it still wakes up all threads in pthreadpool, and them sends some of them to sleep right...
> My biggest concern is that this code doesn't do what you expect: it still wakes up all threads in pthreadpool, and them sends some of them to sleep right...
@Maratyszcza can you please re-review this? In the latest commit I have addressed two of your concerns: - All threads waking up but only some participating. This is fixed by...
Responding here: > Overall, the code needs substantial changes: > > 1. Avoid changing existing internal APIs unless it is absolutely needed to add the new functionality. This PR is...
> I don't expect it to be a common use-case to use different number of thread pool threads depending on which thread called into it, especially with the current implementation...
Tested on windows and mac
cc: @jeffxtang @IvanKobzarev
to exported stacked diffs you want to use ghstack else it will combine changes from diff underneat