executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Manual LICM in op_convolution

Open swolchok opened this issue 1 year ago • 3 comments

Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own.

Reviewed By: kimishpatel, manuelcandales

Differential Revision: D56503574

swolchok avatar Apr 24 '24 03:04 swolchok

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3274

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 2b1426ea1ec2aa9f7e94a2dc2a3b0d565d223ce0 with merge base b7b40ac67adf882e8cf50d85edbb55e5709a9694 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 24 '24 03:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56503574

facebook-github-bot avatar Apr 24 '24 03:04 facebook-github-bot

to exported stacked diffs you want to use ghstack else it will combine changes from diff underneat

kimishpatel avatar Apr 25 '24 04:04 kimishpatel

This pull request has been merged in pytorch/executorch@987a1f98bd0b8f8c39407f6140913954bacb6ed9.

facebook-github-bot avatar Apr 29 '24 22:04 facebook-github-bot