jwasinger
jwasinger
I found out that if a `fallback` is specified, its signature is not specified in the ABI definition (with the exception of whether it is payable or not). Even if...
Before we merge this, I want to reopen so that I get main authorship of the PR.
> Only one thing I noticed: not filling the nonce causes the To address computation possibly wrong for create txes. So this would mean that this is broken in all...
It's not broken. The reason is that the nonce during creation is sourced from the state of the account, not what's in the transaction args.
~~If the provided nonce was not correct, the transaction will fail in `TransactionArgs.TransitionDb`. So I think the current code should be okay (?)~~
Done. I tried to summarize it as succinctly as possible but it got a bit long :)
In this case, it doesn't increase the avenues for debugging. A panic will point directly to the place where the error is caused. Returning it does the same. Seems weird...
Oh, I just remove the error check and don't panic at all. Happy to add that if it would make debugging easier.
Pre-allocated stack size was previously reduced from a default of 1024 to current of 16 in https://github.com/ethereum/go-ethereum/pull/21222 . Maybe a pre-alloced size of 256 is a reasonable compromise between memory...
Beacon root contract update and withdrawals are not properly handled here. However, the BAL spec does not specify how state mutations which occur before/after execution of block txs are handled....