jwasinger

Results 129 comments of jwasinger

> One note that I have already, do we need to check in the autogenerated v2 stubs, or is it possible to generate them on the fly during testing? I'd...

> Looks like there is a code issue in the deploy tree implementation. `bind.MetaData` cannot be copied because it contains a `sync.Mutex` value. The warning was silenced using a `nolint:all`...

I can create a deep-copy utility function to remove the lint exceptions though.

We should add a test case that generates bindings from an abi (not combined-json, so excluding the contract bytecode). Then instantiate a `BoundContract` from an already-deployed instance of the contract...

CI failing `BindingV2ConvertedV1Tests` but I cannot reproduce it locally (even after cloning a fresh copy of the branch). I'm not sure how to restart a build on appveyor without pushing...

One thing that's kind of funky: `LinkAndDeploy` returns a `DeploymentResult` instance which contains a map of deployment addresses and transactions keyed by solidity library link pattern. If we create the...

The current CI failures appear to be from some non-deterministic behavior in the binding... I will look into it further tomorrow. I pushed some commits which attempt to clean up...

The commit before 6c70418313b56f96522d2dcf56f21931ce71a13d is not really complete/correct and should be squashed. but I'm not going to force-push it out atm.

Off the top of my head, I think this PR is mostly in a good spot. I've changed the API through which we interact with contracts fairly significantly: with v2,...

> Especially for fallback, it can support bytes input. It would be very useful to have the fallback encoder and combine it with other function encoder output. So in this...