Jacob Hoffman-Andrews

Results 401 comments of Jacob Hoffman-Andrews
trafficstars

I lean on the side of "close without action." It's true that it's a bit weird and confusing to not have stability information in every possible place. And when I...

@bors r- This is the wrong solution for https://github.com/rust-lang/rust/issues/98341. The link color means something: you can click here. We should avoid creating exceptions if at all possible. The background for...

> It makes the elements' color inherit their parent one. That's usually not what we want. For instance: a paragraph of text might have `color: black`. If there's a link...

> Do you think it would be best to have a creation_date column and partition by that. Then we can automatically clean up old partitions by date? How can we...

Here's another way of thinking about the access IP and user-agent: For the attack we're most worried about (compromised GitHub account), the IP and user-agent of the _login_ are just...

Ah, this makes sense. For `Request::timeout`, where it says: > Sets overall timeout for the request, overriding agent’s configuration if any. That's a little confusing. So instead we should say...

No, you're right; connect timeout is less likely to vary on a per-request basis. It's starting to come back to me now; I think maybe the idea behind making timeout...

Excellent! Yes, I'd definitely be happy to help with reviews.

Another item in this area: It might be good to re-verify the GitHub OAuth token at publish time. If the OAuth token has been revoked, the publish should fail.