Jacob Hoffman-Andrews
Jacob Hoffman-Andrews
Late to the party, but his looks great to me!
@mmaehren Congratulations on publishing! Here's the link to the TLS-Anvil paper: https://tls-anvil.com/assets/files/TLS-Anvil-Paper-c3dbb77c9b27783fe7998d09765061c4.pdf And a link to the video from Real World Crypto: https://youtu.be/WEjgFMuwIAc?t=2255
We also have this problem with NamedGroup, Tls12ClientSessionValue, and Tls13ClientSessionValue in the new ClientSessionStore trait. In the documentation they link to rustls::internal::msgs::enums::NamedGroup, rustls::internal::msgs::persist::Tls12ClientSessionValue, and rustls::internal::msgs::persist::Tls13ClientSessionValue. /cc #1224
Here's the current list of `internals` types that are reachable in the public interface, borrowing a search command from https://github.com/rustls/rustls/issues/1036#issuecomment-1140389210: ``` base::PayloadU16 codec::Reader handshake::DigitallySignedStruct handshake::DistinguishedNames handshake::SessionID handshake::VecU16OfPayloadU16 persist::ClientSessionCommon persist::Tls12ClientSessionValue persist::Tls13ClientSessionValue...
> handshake::SessionID This is no longer part of the public API thanks to #1226. 👍🏻 > These are exported as rustls::client::Tls12ClientSessionValue and rustls::client::Tls13ClientSessionValue: https://github.com/rustls/rustls/blob/main/rustls/src/lib.rs#L424-L426 Unfortunately, rustdoc still chooses to link...
I've filed https://github.com/rustls/rustls/pull/1229 to finish moving AlertDescription, ContentType, and HandshakeType into the public API. Note that the output above showing which items are `internal`-public was incorrect; my sed command was...
> Was this latest list from current main too, so that SessionID is still public even after https://github.com/rustls/rustls/pull/1226? Yep:  > Is there an easy way of figuring out how...
Updated command that includes traits. Running this only turns up `Codec` as an additional output: ``` cargo doc --all-features && find target/doc/rustls -name '*.html' | grep -v internal/ | xargs...
> It doesn't abstract over client vs server, only over client 1.2 vs 1.3, right? Yep, misspoke! Thanks for the correction. > I think the API becomes pretty crappy if...
It doesn't require an extra Box. You can just define an opaque struct and cast the return value to a pointer of that type. From the Rust perspective, *hyper_task would...