Jacob Hoffman-Andrews

Generally looks great! After that one comment tweak, ready to approve.

Some notes from a live conversation: - Fields added to a JSON config should always be exported, because they can't actually be set from a config if not. - But...

There's a bit of follow-up I want to do under this issue, which is to actually log the error.

> I'm fairly opposed to "at most one log line per error" because we have plenty of codepaths that can encounter multiple errors and keep going (or keep retrying). It...

Note: we already have pretty good caching of partial images. In particular, when we build for two different Go versions, everything up to through the build.sh stage is cached, and...

Right, I suspect it's desired in that sense (that there should be keystrokes to jump the cursor around), but not desired in the sense that it overrides browser shortcuts. For...

Have you looked at mkcert? https://github.com/FiloSottile/mkcert It might be closer to what you're looking for. On Sat, Apr 20, 2019, 07:23 Justin wrote: > Hi! > > Would you accept...

Yes, I've installed a minica root certificate on an Android device and used it to validate an HTTPS site. What steps have you taken so far?

Very strange indeed! Does it work if you run in main instead? Or build an Agent explicitly? We do some magic mocking for our own tests that might be mucking...

You're welcome! I'm glad it's been helpful for you. There's not currently a way to generate intermediate certificates, I'm afraid. You may also be interested in mkcert: https://github.com/FiloSottile/mkcert.