Jim Huang

Results 569 comments of Jim Huang

> 2. I have reformatted all relevant files using clang-format. Specifically, I ran the command find src -name '*.[ch]' | xargs clang-format-12 -i with clang-format version 12. Warning: No newline...

Thank @jimmylu890303 for contributing!

It is meaningless to say something like > In Linux v6.8, the 'min_buffers_needed' field of vb2_queue was renamed to 'min_queued_buffers'. Due to this change, the compiler will not find the...

Thank @hungyuhang for contributing!

I tested the latest `dev` branch (commit `076f81`) with `-DMI_OSX_ZONE=ON -DMI_INTERPOSE=OFF`, and both Release and Debug build worked well. Environment: Apple M1 (MacBook Air), macOS v11.4

> @jserv noob question: why doesn't the default GLIBC getcpu() doesn't leverage vdso? In glibc development, `getcpu` was absent until [the commit on Dec 7, 2018](https://sourceware.org/git/?p=glibc.git;a=history;f=sysdeps/unix/sysv/linux/getcpu.c;hb=HEAD). That is the reason...

> I’ve come up with a possible solution for this issue. Maybe we can create a new `unittest/` directory under `tests/`, and put all the unit test related files there....

> 1. Every time I modify `globals.c`, I have to run `update-snapshots`, which can be a bit inconvenient. You can improve `Makefile` to automate this process. > 2. I sometimes...

> 1. Only files in `snapshots` folder would need to have snapshot jsons. > 2. By integrating new testing script, we can still test C source files under `snapshots` and...