Jim Huang

Results 568 comments of Jim Huang

> I think always output the exit code is not a bad thing, maybe this is redundant. Or, it can be determined on top of logging feature. After streamlining the...

> * `mmu_fetch` signature of semu is compatible with `riscv_mem_ifetch` by removing the `vm` and `value` parameter. The I/O interface is embedded inside `riscv_t` so `vm` parameter is no longer...

> You might notice that non-mmu {fetch, read, write} and mmu {fetch, read, write} are duplicated after this changes. To preserve the mnemonic of the function pointers, we might want...

> What about remove `mem_`? Yes, I anticipate removing the legacy memory callback functions prefixed with `mem_` in favor of the newly-added MMU counterparts. Additionally, I am considering the possibility...

> Obviously, we can pass a variable to indicate the width of the data and reduce the number of MMU related functions but I believe one function does one thing...

> Does hooking them at initialization still necessary in this way? Not necessary. Let's proceed.

Thanks for spotting this issue. Can you point out more in current example code?

Thank @NOVBobLee for contributing!