vcam icon indicating copy to clipboard operation
vcam copied to clipboard

Fix build issues with Linux v6.8 and later

Open hungyuhang opened this issue 1 year ago • 1 comments

  1. Rename min_buffers_needed member in struct vb2_queue to min_queued_buffers according to the changes in Linux v6.8. (The change described above in the Linux Kernel source code can be viewed at: https://github.com/torvalds/linux/commit/80c2b40a51393add616a1fd186a1cc10bd676a3f)

  2. Remove FBINFO_FLAG_DEFAULT flag, as this flag was removed in Linux v6.6 and later. (The change described above in the Linux Kernel source code can be viewed at: https://github.com/torvalds/linux/commit/0444fa357c16a4c36c6c6e3ef13e690875fad208)

hungyuhang avatar Jun 23 '24 01:06 hungyuhang

It is meaningless to say something like

In Linux v6.8, the 'min_buffers_needed' field of vb2_queue was renamed to 'min_queued_buffers'. Due to this change, the compiler will not find the declaration of the field 'min_buffers_needed' and will cause compilation error when building with Linux v6.8 and later.

The compiler is not related to the changes by Linux kernel internally. You should analyze the upstream changes for the considerations and/or impacts.

jserv avatar Jun 27 '24 09:06 jserv

It is meaningless to say something like

In Linux v6.8, the 'min_buffers_needed' field of vb2_queue was renamed to 'min_queued_buffers'. Due to this change, the compiler will not find the declaration of the field 'min_buffers_needed' and will cause compilation error when building with Linux v6.8 and later.

The compiler is not related to the changes by Linux kernel internally. You should analyze the upstream changes for the considerations and/or impacts.

I've updated the commit messages.

hungyuhang avatar Jul 15 '24 02:07 hungyuhang

Thank @hungyuhang for contributing!

jserv avatar Jul 15 '24 02:07 jserv