Josh McKinney

Results 1010 comments of Josh McKinney

Actually, it's a little more complex than this. Because the Apache license adds some restrictions, those restrictions are incompatible with the MIT license which has a "without restriction" clause. It's...

Yep - that policy makes everything MIT licensed fine. I had a deeper chatgpt conversation about it, digging into the actual clauses. It brought up many valid points, a few...

Regarding the original example: A much more succinct way to rewrite this would use the vertical / horizonal constructors and the areas() method like so: ```rust let form_height = 12;...

> Something I do want to add soon is a Rect::layout() method, which would change these to e.g.: - https://github.com/ratatui/ratatui/pull/1909 adds those methods

For a homogenous grid layout where items flow left to right, top to bottom, the second example becomes: ```rust let vertical = Layout::vertical([Constraint::Fill(1), Constraint::Fill(3)]).spacing(2); let horizontal = Layout::horizontal([Constraint::Length(10), Constraint::Fill(1)]).spacing(1); let...

We renamed the methods into... This would require a small trait and implementing the trait on the relevant types. Alternatively augmenting the existing ToLine trait to add these functions could...

I'd like you to consider the complexity that this would add to the implementation. There's two things that are at play here. Are you more concerned about: - whether the...

Think about what that would mean to the implementation. I'd suggest try implementing this to understand why it's not a good trade off.

There's many functions / configurations about to how radio button or checklist can work that this could cover. I think it would be useful to explore these ideas outside of...

previous issues: - https://github.com/ratatui/ratatui/issues/1387 - https://github.com/ratatui/ratatui/issues/1346 - https://github.com/ratatui/ratatui/issues/475