Josh McKinney

Actually - the replacement for the libc::isatty call was relatively simple. https://github.com/rustcoreutils/posixutils-rs/pull/399/commits/76fa884a135af72ef138f6511d6391dcbb639df8 https://github.com/rustcoreutils/posixutils-rs/pull/399/commits/cf26e81a49b764f2f532285907d3223b62fa4b8f - removed libc from the deps for `test` Manually tested this with: ```shell target/debug/test -t 0 ||...

I'm not sure I follow. Using IsTerminal is what this PR does.

Copying my comment from the original comment: >No - but that probably requires a bit more design than the labels, as it implies a few things (order of drawing, order...

One thing I'm not 100% sure of is whether it's better to use just the order in one place and add a legend order, or adding order for both. I...

I think 0 based makes a bit more intuitive sense to me than i32, and it sounds like if you're questioning the intuitiveness you might agree somewhat. What if we...

That seems like it would actually be a reasonable change thinking this through. Would that solve most of your problem without having to add manual ordering? Edit: this might break...

Neat idea and effect. I may take me a bit of time to dig into the code change for this one. A small question though, I wonder whether this makes...

I'd like to suggest also reaching out to the rust-analyzer owners to see if there's some scope to pull this into their responsibility area. While this isn't purely a Rust...

> I started the cleanup, but sometimes the `where` feels better readable, e.g. > Do we still want to fully commit to changing all signatures to ? No :) I...

Weird. Maybe git bisect to find out when the problem was introduced? Guessing somewhere in the module split / examples stuff.