Josh McKinney

Results 988 comments of Josh McKinney

We don't worry too much about bot messages (this and code cov problems). They're there to remind us to fix up stuff before merging. Feel free to ignore it until...

Great idea. Some questions: - Do we want to make it possible to use custom shadow symbols? - How would offsets that are > 1 work? - Do we want...

Looking pretty neat :)

That's pretty neat. By making that a trait though we'd be able to add a few different implementations (i.e. the dimmed function here could be something which is provided by...

I meant if ShadowType was a trait, with a couple of implementations rather than an enum with a Custom variant. So we'd get something like: ```rust trait ShadowFilter { ......

(P.s. I don't know which way makes more sense - there's a simplicity vs expandability tradeoff here that should be considered)

Half of this is sort of implemented in https://github.com/ratatui/ratatui/pull/1596 I think taking the approach that you're suggesting here of the Rect / Position / Offset being similar to the integer...

I was answering a problem on the forums just now which had to do with output being written to the terminal by another thread. A workaround approach for always re-rendering...

> I tried your implementation, and it is working... at least a little bit. But there are still some cases where old text is not being deleted How about doing...

(also - apologies for not getting you a response on this sooner. It's not currently added to our automatic notifications in discord so I accidentally wasn't following the repo)