Josh McKinney

Results 1012 comments of Josh McKinney

This looks sick! Doing a bit of a review now.

Looks pretty nice now. Some little things: hover over the names can wrap a bit odd: Space around the names is a bit inconsistent: Padding above / below the images...

This is related to the recent unicode-width change in 0.1.13, which makes these characters now be measured as one character wide instead of 0 characters. See https://github.com/unicode-rs/unicode-width/issues/55 (closed as WONTFIX)...

@EdJoPaTo you might also take a look at https://github.com/ratatui-org/ratatui/issues/1227, which I was writing up unrelated to this, but which also applies. For your specific use case (wanting to pass thorugh...

Yup got it. I mistakenly thought that doing making a dependency on 0.1 would lead to cargo resolving that to 0.1.13 even in the presence of a pinned version in...

I was running a version of the terminal theme that was fairly old. I had a redirect page setup in my content and running Zola serve stated that get_url required...

Caching in the cell instead of just in the buffer gives a pretty massive speed up: ``` buffer/diff time: [54.856 µs 54.994 µs 55.140 µs] change: [-45.189% -44.918% -44.665%] (p...

Hrm, this clippy lint is a bit of a worry: ``` error: a `const` item should never be interior mutable --> src/buffer/cell.rs:72:5 | 72 | / pub const EMPTY: Self...

> The failing tests are more simple to fix. famous last word :D

> honestly speaking I am confused: flamegraph and diff function measure shows big change, but in the runtime there is absolutely no influence: component-generated template burns 1 CPU core at...