Josh McKinney
Josh McKinney
> I see, so your solution would be to just bubble the error all the way, and log it or in a similar vain handle it Yes basically.
I'd love to see some benchmarks on the diff function to measure the current performance as one easy-ish part of this. It's actually possible to skip the entire rendering stack...
Something that would also be helpful here would be some flamegraphs (install cargo-flamegraph if you haven't already). That will show where the time is being spent (i.e. that the width...
The code that displays the tab is https://github.com/microsoft/vscode/blob/b227e84a88ed27b9774ceb9aad3511c9c58b3dde/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts#L600-L601
The core motivation was to within a library (Ratatui) to be able to centrally define, describe and store `Counter`/`Gauge`/`Histogram` away from the line of code where changes are recorded, to...
Makes sense. I've removed the derives from the metrics-observer and benches, and removed the trait changes. Rebased on main to pick up the other merged changes. Clippy lints are unrelated...
Rebased on main. Fixed the unnecessary import. Added _len debug fields on Fanout, FanoutBuilder, Router, and RouterBuilder.
No probs. For more on how this is useful to me, see https://github.com/ratatui/ratatui/pull/1351, in particular the code where I centralize the initialization of metrics for each struct that uses them...
TODO: write up a better rationale for the public export and note the sorts of problems devs might / have run into when these get out of sync. Include recommendation...
> When setting up a panic hook with an external crate, there should also be the panic hook with std only methods. Added