Josh Goebel

Results 1642 comments of Josh Goebel
trafficstars

I would guess a block is likely incompatible with the design of the entire system. But that's a guess. And yes a callback would certainly be another workable possibility. For...

> However, when I call sync() to go to content bank 1, it does not render using the vbank 1 palette from content bank 1, but rather with the one...

> it does not render using the vbank 1 palette from content bank 1 I also can't parse this, as there is only a single VBANK1 in all the hardware......

The only open question is how does `sync` `SCREEN` work with `vbank`ing... and my guess would be that it syncs cartridge data into the ACTIVE vbank, though I could be...

> since each content bank allows the definition of a separate vbank1 palette It does not. Could you point to any specific places on the wiki that lead to this...

For example: ```lua vbank(1) sync(screen | palette, 3) vbank(0) ``` Should copy the `SCREEN` and `PALETTE` from cartridge `BANK3` into `VRAM` (specifically `VBANK1`).

> but the editor itself. Ah... I see now... because our save file format groups the palettes together... so you're right, you have 16 palettes... spread across 8 banks. Sometimes...

> it pulls the palette over from cartridge bank 3, only changing vbank 0, which is expected, Actually I'm not sure that's expected - or I don't think it's 100%...

@nesbox It sounds like `sync` may not be taking `vbank` into account - that the default palette is always getting copied over the "active vbank" palette... I'm thinking we should...

> We have started to use clock() https://en.cppreference.com/w/c/chrono/clock std function here to measure time in 1.0, maybe you have a piece of code to profile it? From the docs: >...