Jon Schlinkert

regarding dependency versions, a pull request with passing unit tests is always preferable to creating an issue. > Although it does not harm but it's polluting our log file similarly,...

> have you benchmarked this vs baseline vs wasm? curious for 1, 1000, 1M, 100M tokens. If there is a perf difference at different scales, we should consider toggling algorithms...

I guess my only feedback is that it’s confusing that a new word is being coined for dirname. I had no idea what parentPath was supposed to mean, and I’ve...

Hmm, `prompt` is being called at the bottom of `rebrand.js` but it's not being awaited. I'm not sure what else might be causing it.

K, sounds like this is technically resolved then. I'll go ahead and close. Let us know if you want to discuss further.

Thanks, this will need to be changed in the template that's used to generate the readme. I'll leave this open as a reminder to myself to do that when I...

Hi @ghiscoding, thanks for creating the issue. It looks like picomatch is correct in those examples. If you set `matchBase`, you're saying you want to match the file's base name,...

I’ll help you figure it out either way. I’m not at my computer, but I’ll try to look at this tomorrow. Sent from my iPhoneOn Oct 1, 2024, at 5:46 ...

> but I just wanted to contribute to the most useful javascript library :/ To be clear, is this a real PR, or are you trolling and violating GitHub's code...

> add node 0.10 and 0.12 back to the build matrix? Not build matrix, just the `node_js` property.