John Patrick Morgan

Results 83 comments of John Patrick Morgan

Thanks @strangeliu for the PR. I haven't yet had a chance to look at it in detail but I will try to soon.

Thanks for raising this issue @FredericRuaudel and for the nice reproduction. I haven't looked too deeply yet, but my hunch is that the `WithViewStore` is causing unnecessary re-renders of screens...

Thanks for raising this issue @Sajjon! This is a feature I've really wanted to add but I've hit issues. I'll document the issues and my progress here. Most updates to...

Hi @Sajjon, thanks for raising and for such a comprehensive example! :smile: You are correct that the issue is described (albeit poorly) in that section of the README. To explain...

By the way, I'm also intending to improve the documentation around child coordinators to better describe this limitation!

Thanks @Sajjon I have a better understanding of the problem now. I can see why you want to be able to break down your coordinators in that way. I'd certainly...

Thanks for raising this issue @josephktcheung. I think that the `NavigationLink presenting a value...` warning must be spurious, as there are no NavigationLinks that present values in use (FlowStacks uses...

Thanks @JosephDuffy. My guess is that these are erroneous warnings: the text refers to `NavigationLink presenting a value`, but the only `NavigationLink`s used, as you found, are not using the...

Thanks, I'll leave it open for visibility and hope it gets resolved.

Thanks, I still think this is an erroneous message. I can trigger it with the following vanilla SwiftUI code: ```swift import SwiftUI @main struct NavigationWarningLogDemoApp: App { var body: some...