John Patrick Morgan

Results 86 comments of John Patrick Morgan

Hi! Thanks for raising this issue. Sorry it's taken a long time to respond but I wanted to do it justice. I think there are three approaches to sharing data...

@maguerrieri Thanks very much for opening this PR - I hadn't realised the library was crashing on iOS 13! I agree with @theedov that adding a dependency on `SwiftUIBackports` feels...

Thanks @maguerrieri! I'll try to experiment with lightweight ways of achieving this too.

I think the best approach for this would be to maintain an `ios13` compatibility branch with the proposed change and bump the main library's minimum deployment to iOS/tvOS 14.0.

I've set up an [iOS 13](https://github.com/johnpatrickmorgan/NavigationBackport/compare/ios13) branch with your changes - thanks a lot @maguerrieri ! I've also bumped the minimum deployment targets for iOS and tvOS to 14. >...

> We exactly specify all of our versions, so not getting automatic updates suits me fine. Any other ideas on how to handle versioning? Thanks for clarifying @maguerrieri. In that...

I haven't tested yet but I wonder if this message no longer shows in the latest Xcode 14.1 beta: https://www.donnywals.com/xcode-14-publishing-changes-from-within-view-updates-is-not-allowed-this-will-cause-undefined-behavior/.

Hi, thanks for raising this issue. I'm afraid `navigationViewStyle(.columns)` is the only navigation view style supported on macOS at the moment. It gives the behaviour you've described. From your description,...

Hi @igortxito! On macOS, you can have a coordinator whose root screen is the side bar, that pushes screens into the second (and possibly third) columns, e.g.: ```swift NavigationView {...

Thanks for raising this issue @josephktcheung. I really wish macOS would support `StackNavigationViewStyle`, it seems strange that it doesn't. Hopefully that will come soon. If I understand correctly, you're suggesting...